Fix RecursiveASTVisitor to visit copy expressions of captured variables in blocks (ObjC++11)

Mathieu Baudet mathieu.baudet at gmail.com
Wed Jun 11 21:23:58 PDT 2014


Oups I thought I had tested but had not. Here is the real, and
hopefully final, patch.

2014-06-11 12:33 GMT-07:00 Mathieu Baudet <mathieu.baudet at gmail.com>:
> Hi Alp,
>
> Sure. Here is another patch using the new syntax.
>
> -- Mathieu
>
> 2014-06-07 11:46 GMT-07:00 Alp Toker <alp at nuanti.com>:
>>
>> On 07/06/2014 03:44, Mathieu Baudet wrote:
>>>
>>> Hi,
>>>
>>> I found a corner case in ObjC++11 where the RecursiveASTVisitor could
>>> miss the body of a block.
>>>
>>> Please find the patch in attachment (unit test included).
>>
>>
>> The approach looks OK but please simplify with for (const auto &I :
>> D->captures()).
>>
>> Alp.
>>
>>>
>>> -- Mathieu
>>
>>
>> --
>> http://www.nuanti.com
>> the browser experts
>>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang_RecursiveASTVisitor_VisitsCopyExpr.patch
Type: application/octet-stream
Size: 3578 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140611/6796f432/attachment.obj>


More information about the cfe-commits mailing list