r210294 - Provide fallback locations for backend remarks

[Alp Toker]

On 06/06/2014 14:06, Timur Iskhodzhanov wrote:
>
> 2014-06-06 2:11 GMT+04:00 Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>>:
>
>     Modified: cfe/trunk/test/Frontend/optimization-remark.c
>     URL:
>     http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/optimization-remark.c?rev=210294&r1=210293&r2=210294&view=diff
>     <http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Frontend/optimization-remark.c?rev=210294&r1=210293&r2=210294&view=diff>
>     ==============================================================================
>     --- cfe/trunk/test/Frontend/optimization-remark.c (original)
>     +++ cfe/trunk/test/Frontend/optimization-remark.c Thu Jun  5
>     17:11:12 2014
>     @@ -3,10 +3,8 @@
>      // always trigger the inliner, so it should be independent of the
>      // optimization level.
>
>     -// RUN: %clang_cc1 %s -Rpass=inline -Rpass-analysis=inline
>     -Rpass-missed=inline -O0 -gline-tables-only -emit-obj -verify -S
>     -o /dev/null 2> %t.err
>     -
>     -// RUN: %clang -c %s -Rpass=inline -O0 -S -o /dev/null 2> %t.err
>     -// RUN: FileCheck < %t.err %s --check-prefix=INLINE-NO-LOC
>     +// RUN: %clang_cc1 %s -Rpass=inline -Rpass-analysis=inline
>     -Rpass-missed=inline -O0 -gline-tables-only -emit-llvm-only -verify -S
>     +// RUN: %clang_cc1 %s -DNDEBUG -Rpass=inline -emit-llvm-only
>     -verify -S
>
>
> The "-o /dev/null" was important, I believe?
> It fails when run from a read-only checkout.
> ... or failed until r210323.

Thanks for the report. It turns out the -S was left over when these got 
converted from %clang to %clang_cc1.

Fixed in r210326.

Alp.

-- 
http://www.nuanti.com
the browser experts