count() patch to unsigned for DenseMap, DenseSet, ScopedHashTable, ValueMap
richard at metafoo.co.uk
Thu Jun 5 17:21:38 PDT 2014
On Tue, Jun 3, 2014 at 2:11 PM, Rafael Espíndola <rafael.espindola at gmail.com
> + /// count -
> While at it, please drop the name from the comment.
> I think the patch is OK. Richard, do you know what is the reason the
> stl uses size_type?
I don't know for sure, but probably for consistency and ease of
specification of the interface.
[It's been like that since Stepanov and Lee's original implementation,
where the red-black tree implementation shared by set,map,multiset,multimap
did not distinguish between the unique and non-unique cases in its 'count'
> On 23 December 2013 06:51, Yaron Keren <yaron.keren at gmail.com> wrote:
> > The count() function for STL datatypes returns unsigned, even where it's
> > only 1/0 result like std::set. Some of the LLVM ADT already return
> > count(), while others still return bool count().
> > In continuation to r197879, this patch modifies DenseMap, DenseSet,
> > ScopedHashTable, ValueMap:: count() to return unsigned instead of bool, 1
> > instead of true and 0 instead of false.
> > Yaron
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the cfe-commits