[PATCH] libcxxabi/unwind: Add support for ARM EHABI in AddressSpace.hpp

Nick Kledzik kledzik at apple.com
Tue Jun 3 17:09:22 PDT 2014


On Jun 3, 2014, at 4:58 PM, Dana Jansens <danakj at google.com> wrote:

> 
> The setjump-longjump is similar to this.  It does not use the lower level libunwind APIs and it has its own phase1/phase2 unwinding code separate from the Itanium style.  So, it makes sense to me for the ARM EHABI  implementation to be in its own Unwind-ehabi.c file and do not use libunwind under it.  This was part of why I thought of EHABI as being a different unwinder than the zero-cost unwinder in terms of _LIBUNWIND_BUILD_blah.
> 
> We discussed making a change like that, but we're more concerned with upstreaming first right now, rather than keeping this all on a private repo. Since the way we developed this was sharing code with the itanium implementation as much as possible, are you okay with upstreaming it in this fashion and then looking at moving it away in the future?
>  
Can you be more specific about what you mean by “in this fashion” and “moving it away in the future”.

-Nick
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140603/928f7e87/attachment.html>


More information about the cfe-commits mailing list