count() patch to unsigned for DenseMap, DenseSet, ScopedHashTable, ValueMap

Rafael EspĂ­ndola rafael.espindola at
Tue Jun 3 14:11:06 PDT 2014

+  /// count -

While at it, please drop the name from the comment.

I think the patch is OK. Richard, do you know what is the reason the
stl uses size_type?

On 23 December 2013 06:51, Yaron Keren <yaron.keren at> wrote:
> The count() function for STL datatypes returns unsigned, even where it's
> only 1/0 result like std::set. Some of the LLVM ADT already return unsigned
> count(), while others still return bool count().
> In continuation to r197879, this patch modifies DenseMap, DenseSet,
> ScopedHashTable, ValueMap:: count() to return unsigned instead of bool, 1
> instead of true and 0 instead of false.
> Yaron
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at

More information about the cfe-commits mailing list