[PATCH] libcxxabi/unwind: Add support for ARM EHABI _Unwind_VRS_Set/Get/Pop methods.

Renato Golin renato.golin at linaro.org
Tue Jun 3 08:49:44 PDT 2014


On 2 June 2014 18:02, Dana Jansens <danakj at google.com> wrote:
> Hi Nick,
>
> This patch builds on my previous patch[1] (using the config.h #define) to
> provide the virtual register set methods from the ARM EHABI ssection 7.5.


Hi Dana,

+    case _UVRSC_VFP: {
+      unw_fpreg_t value;
+      switch (representation) {
+        case _UVRSD_VFPX:
+          // TODO(ajwong): What does this mean?
+          break;

Isn't this just a VLDM/VSTM into/from D registers? Should be similar
to the other 64-bit cases, no?

The rest looks ok to me, but please wait for Nick's review before commit.

cheers,
--renato



More information about the cfe-commits mailing list