r210075 - Don't assume an implicit IntrusiveRefCntPtr -> bool operator.

Rafael EspĂ­ndola rafael.espindola at gmail.com
Tue Jun 3 06:38:45 PDT 2014

>> -  bool hasInvocation() const { return Invocation != nullptr; }
>> +  bool hasInvocation() const { return (bool)Invocation; }
> Perhaps IntrusiveRefCntPtr could ues an operator==(nullptr_t) though?

Sure, r210100 and r210101.

> (& can we move from IntrusiveRefCntPtr to std::shared_ptr with
> std::enable_shared_from_this where necessary?)

Maybe. As a current side project I am trying to change llvm to use
std::errror_code, so I will not be looking at IntrusiveRefCntPtr right
now, but if you have the time it would be nice to try.


More information about the cfe-commits mailing list