[PATCH] add BugReporterVisitor to PthreadLockChecker

Jordan Rose jordan_rose at apple.com
Mon Jun 2 15:54:42 PDT 2014

Good idea! Rather than add another state, though, it might be better to use a custom tag for the initialization transition. That way we don't need to have "S->isInitialized() || S->isUnlocked()" anywhere. What do you think?

On Jun 2, 2014, at 2:26 , Daniel Fahlgren <daniel at fahlgren.se> wrote:

> Hi,
> This patch adds a BugReporterVisitor to the pthread lock checker. The
> checker was slightly extended to be able to distinguish between a lock
> that is unlocked and one that is initialized for the event message to be
> correct.
> Btw, is there some way to add a stack hint when tracking a MemRegion and
> not a SymbolRef?

I don't think we have one yet, but feel free to augment the existing StackHintGeneratorForSymbol to support both. I imagine most of the logic is the same.


More information about the cfe-commits mailing list