[libcxx] r210019 - Remove unused code in a libc++ test.

Nico Weber thakis at chromium.org
Mon Jun 2 05:13:09 PDT 2014


On Mon, Jun 2, 2014 at 2:00 PM, Nico Weber <nicolasweber at gmx.de> wrote:

> Author: nico
> Date: Mon Jun  2 07:00:08 2014
> New Revision: 210019
>
> URL: http://llvm.org/viewvc/llvm-project?rev=210019&view=rev
> Log:
> Remove unused code in a libc++ test.
>
> Other tests in this directory use this type, so it's probably copypasta
> from
> there.
>
> (test_buf only forwards to the superclass in all tests where it's used
> though,
> so I wonder if it can be replaced with just using filebuf / wfilebuf
> everywhere?)
>

No: test_buf isn't unused, it's used to make protected members such
as pbackfail() public for testing. So it needs to stay around in the other
tests.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140602/84c9bb42/attachment.html>


More information about the cfe-commits mailing list