r209915 - Add a FIXME for a bug Doug pointed out in code review.

Richard Smith richard-llvm at metafoo.co.uk
Fri May 30 12:44:17 PDT 2014


Author: rsmith
Date: Fri May 30 14:44:17 2014
New Revision: 209915

URL: http://llvm.org/viewvc/llvm-project?rev=209915&view=rev
Log:
Add a FIXME for a bug Doug pointed out in code review.

Modified:
    cfe/trunk/include/clang/Basic/Module.h

Modified: cfe/trunk/include/clang/Basic/Module.h
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/Basic/Module.h?rev=209915&r1=209914&r2=209915&view=diff
==============================================================================
--- cfe/trunk/include/clang/Basic/Module.h (original)
+++ cfe/trunk/include/clang/Basic/Module.h Fri May 30 14:44:17 2014
@@ -425,6 +425,10 @@ public:
 
   /// \brief Determine whether the specified module would be visible to
   /// a lookup at the end of this module.
+  ///
+  /// FIXME: This may return incorrect results for (submodules of) the
+  /// module currently being built, if it's queried before we see all
+  /// of its imports.
   bool isModuleVisible(const Module *M) const {
     if (VisibleModulesCache.empty())
       buildVisibleModulesCache();





More information about the cfe-commits mailing list