r209489 - Fix a bug in xmmintrin.h.

Chandler Carruth chandlerc at google.com
Thu May 22 21:29:57 PDT 2014


On Thu, May 22, 2014 at 10:27 PM, Akira Hatanaka <ahatanaka at apple.com>wrote:

> I thought about adding a test case, but wasn’t sure how this fix should be
> tested.
>
> I don’t think it’s a good idea to check the bitcode clang generates, is it?
>

We routinely test the generated IR (without optimizations)?


>
> On May 22, 2014, at 8:35 PM, Chandler Carruth <chandlerc at google.com>
> wrote:
>
>
> On Thu, May 22, 2014 at 6:38 PM, Akira Hatanaka <ahatanaka at apple.com>wrote:
>
>> Author: ahatanak
>> Date: Thu May 22 19:38:07 2014
>> New Revision: 209489
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=209489&view=rev
>> Log:
>> Fix a bug in xmmintrin.h.
>>
>> The last step of _mm_cvtps_pi16 should use _mm_packs_pi32, which is a
>> function
>> that reads two __m64 values and packs four 32-bit values into four 16-bit
>> values.
>>
>
> This (somewhat obviously) needs a test case.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140522/6036267e/attachment.html>


More information about the cfe-commits mailing list