[cfe-dev] clang::CodeGen::CodeGenModule::GetOrCreateLLVMGlobal

Rafael Espíndola rafael.espindola at gmail.com
Thu May 22 16:41:47 PDT 2014


r209484, thanks.

On 22 May 2014 18:49, John McCall <rjmccall at apple.com> wrote:
> On May 22, 2014, at 5:56 AM, Rafael Espíndola <rafael.espindola at gmail.com> wrote:
>> On 22 May 2014 05:04, Vassil Vassilev <vasil.georgiev.vasilev at cern.ch> wrote:
>>> Hi Rafael,
>>>  Do you think we could rely for this case on post commit review?
>>
>> According to policy no.
>>
>> Richard, can you help us with this 2 month old code review? A rebased
>> patch is attached.
>
> Did I really not review this?  I’m sorry, I think I must have had it confused with some other change.  Yes, this is great, and I’m very sorry about the delay.
>
> John.




More information about the cfe-commits mailing list