[PATCH] Make dead return statement detection more robust against changes in the CFG.

[Manuel Klimek]

On Thu, May 22, 2014 at 6:42 PM, Jordan Rose <jordan_rose at apple.com> wrote:

> Okay, I think I understand now. If the first dead statement is the first
> expression in a return statement, and then there's a temporary destructors
> block, and then the return statement, then we'd still want to treat that as
> part of the return statement. And that happens right now because we don't
> optimize out the case with no control flow.
>
> I'm worried, though, that this will catch something in a dead else block
> and go sailing off the end to look for a return statement, build a parent
> map, and then not actually find anything (of course). It seems like a fair
> amount of extra work. Then again, we have already decided to emit a
> diagnostic at this point, so I guess it's okay.
>

That was the exact line of thought I went through, too... I also tried to
come up with a better way, but didn't have a good idea...


>
> http://reviews.llvm.org/D3638
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140522/0f978e14/attachment.html>