Question about existing tests for [dcl.stc]

Aaron Ballman aaron at aaronballman.com
Mon May 19 14:05:22 PDT 2014


Specific patch to address the problem is attached.

~Aaron

On Mon, May 19, 2014 at 12:59 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> We have a test that's XFAILed for everything:
> test\CXX\dcl.dcl\dcl.spec\dcl.stc\p10.cpp
>
> However, I can see no reason why this test should be failed for all
> platforms. The only issue I see with the test is that the wording for
> a diagnostic may need to be updated.
>
> mutable struct s1 {}; // expected-error{{'mutable' cannot be applied
> to non-data members}}
>
> Could be: 'mutable' is not permitted on a declaration of a type
>
> which is what currently fires for that line in the test. However, that
> is currently fired as an extension warning, not an error, for C++. Am
> I correct in thinking that warning should be upgraded to an error for
> C++, the test updated for the new wording, and then the XFAIL can go
> away?
>
> ~Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: mutable.patch
Type: application/octet-stream
Size: 2000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140519/8f49ff21/attachment.obj>


More information about the cfe-commits mailing list