[PATCH] Allow dllimport/dllexport on inline functions and get the linkage right

Reid Kleckner rnk at google.com
Wed May 14 18:33:01 PDT 2014


LGTM with a comment

================
Comment at: lib/AST/ASTContext.cpp:7802
@@ +7801,3 @@
+static GVALinkage fixGVALinkageForDLLAttribute(GVALinkage L, const Decl *D) {
+  if (D->hasAttr<DLLImportAttr>()) {
+    if (L == GVA_DiscardableODR || L == GVA_StrongODR)
----------------
This should have a comment about the semantics of dllimport and dllexport, and link to the MSDN doc on dllexport with inline functions:
http://msdn.microsoft.com/en-us/library/xa0d9ste.aspx

http://reviews.llvm.org/D3772






More information about the cfe-commits mailing list