[PATCH] [analyzer][Review request] Improved checker lists.

Jordan Rose jordan_rose at apple.com
Tue May 13 09:30:03 PDT 2014


Did you write expandcollapse.js yourself? Or does it have a license we need to mention? Don't forget the images when you commit.

Content looks good! (with a few inline comments, of course). If there are no issues with the license thing, please commit.

================
Comment at: www/analyzer/alpha_checks.html:21
@@ +20,3 @@
+<h1>Alpha Checkers</h1>
+Experimental checkers in addition to the <a href = "available_checks.html">Default Checkers</a>.
+<ul>
----------------
We should probably include something like: "These are checkers with known issues or limitations that keep them from being on by default. They are likely to have false positives. Bug reports are welcome but will likely not be investigated for some time. Patches welcome!"

================
Comment at: www/analyzer/alpha_checks.html:104
@@ +103,3 @@
+(C, C++)</span><div class="descr">
+Warn about unintended use of identical expressions in operators.</div></div></td>
+<td><div class="exampleContainer expandable">
----------------
It supports more than just operators now. "Warn about suspicious uses of identical expressions"?

http://reviews.llvm.org/D3457






More information about the cfe-commits mailing list