[PATCH] [Driver] Do not lose already detected set of toolchain's multilibs while iterating over different library path suffixes and different library versions.

Jon Roelofs jonathan at codesourcery.com
Thu May 8 16:22:58 PDT 2014


================
Comment at: lib/Driver/ToolChains.cpp:1906
@@ -1892,4 +1905,3 @@
   for (const auto &candidate : candidates) {
-    Multilibs.clear();
-    Multilibs.combineWith(*candidate);
-    if (Multilibs.select(Flags, SelectedMultilib)) {
+    Result.Multilibs.combineWith(*candidate);
+    if (Result.Multilibs.select(Flags, Result.SelectedMultilib)) {
----------------
Don't we need a

Result.Multilibs.clear();

here, that way Multilibs from different candidate sets don't get used together?


Or maybe I don't fully understand the problem that this (or the other patch) solves...

http://reviews.llvm.org/D3684






More information about the cfe-commits mailing list