[patch] tblgen: Modularize the diagnostic emitter

[Tobias Grosser]

On 06/05/2014 23:17, Ben Langmuir wrote:
> Hi Tobias,
>
> LGTM, your refactoring made this much clearer to me as a first-time reader of this code. A couple of minor things:
>
>> +/// @brief Emit the array of diagnostic subgroups.
>> +///
>
> nitpick: \brief seems to be the generally accepted style

Fixed.

>> +/// The array of diagnostic subgroups contains for each group a list of its
>> +/// subgroups. The individual lists are separated by '-1'. Groups with no
>> +/// subgroups are skipped.
>> +///
>> +///   static const int16_t DiagSubGroups[] = {
>> +///     /* Empty */ -1,
>> +///     /* DiagSubGroup0 */ 142, -1,
>> +///     /* DiagSubGroup13 */ 265, 322, 399, -1
>> +///   }
>
> \code, \endcode

Added.

>
>>     for (std::map<std::string, GroupInfo>::const_iterator
>> -       I = DiagsInGroup.begin(), E = DiagsInGroup.end(); I != E; ++I) {
>> +           I = DiagsInGroup.begin(),
>> +           E = DiagsInGroup.end();
>> +       I != E; ++I) {
>
> Range-based for maybe?

I moved to range based for loops.

Submitted in r208136.

Thanks for the review,
Tobias