[patch] tblgen: Modularize the diagnostic emitter

[Richard Smith]

LGTM, thanks.


On Tue, May 6, 2014 at 12:49 AM, Tobias Grosser <tobias at grosser.es> wrote:

> Ping.
>
>
> On 26/02/2014 13:23, Tobias Grosser wrote:
>
>> Hi,
>>
>> I would like to commit this patch (mostly mechanical)
>>
>> [PATCH] tblgen: Modularize the diagnostic emitter
>>
>> Replace a large monolithic function with per-table functions which all
>> nicely fit on my screen. I also added documentation to each function
>> that describes what kind of tables are generated and which information
>> is contained. Finally, I run clang-format over the moved code.
>>
>> I spent a significant amount of time to understand this code when
>> reasoning about possible extensions to the diagnostic interface to
>> support 'remark' diagnostics. This change will definitely help such an
>> implementation, but already by itself it will save other people a lot of
>> time when trying to understand this functionality.
>>
>> Even though the patch touches the full function, it is mostly
>> mechanical. No functional change intended. The generated tblgen files
>> are identical.
>> ---
>>   utils/TableGen/ClangDiagnosticsEmitter.cpp | 257
>> +++++++++++++++++++++--------
>>   1 file changed, 185 insertions(+), 72 deletions(-)
>>
>> As it touches a couple of lines, I would appreciate a quick review.
>>
>> Cheers,
>> Tobias
>>
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140506/46348fb2/attachment.html>