r207997 - Fix pr19653.

[Richard Smith]

On Mon, May 5, 2014 at 3:33 PM, Rafael Espíndola <rafael.espindola at gmail.com
> wrote:

> > In this case, it'd be nice to say that the aliasee has no explicit
> section
> > attribute.
>
> I am not sure I understand the wording you want. The attached patch
> adds a different warning for the case where there are 2 explicit
> sections. Is that more or less what you have in mind?


I think I'd like something like:

warning: attribute 'section' on alias ignored; an alias is in the same
section as its target
note: target of alias is in section 'blah'
... or ...
note: target of alias has no section specified

(... with the note pointed at the target of the alias where possible.)

I wonder whether we should warn regardless of whether the sections match,
though: having both a section attribute and an alias attribute on the same
declaration makes no sense, as far as I can tell.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140505/65d44bd9/attachment.html>