r206687 - Move ObjC Cocoa.h header test to Headers

[Alp Toker]

Files moved as suggested in r207936.

Alp.


On 21/04/2014 18:37, Richard Smith wrote:
> On Mon, Apr 21, 2014 at 8:24 AM, Alp Toker <alp at nuanti.com 
> <mailto:alp at nuanti.com>> wrote:
>
>
>     On 21/04/2014 01:50, Richard Smith wrote:
>
>         On Sat, Apr 19, 2014 at 12:07 PM, Alp Toker <alp at nuanti.com
>         <mailto:alp at nuanti.com> <mailto:alp at nuanti.com
>         <mailto:alp at nuanti.com>>> wrote:
>
>             Author: alp
>             Date: Sat Apr 19 14:07:24 2014
>             New Revision: 206687
>
>             URL: http://llvm.org/viewvc/llvm-project?rev=206687&view=rev
>             Log:
>             Move ObjC Cocoa.h header test to Headers
>
>             This tests for broad compatibility with platform SDK
>         headers using
>             the clang
>             driver and so belongs alongside the other header
>         ingtegration tests.
>
>
>         I agree that test/SemaObjC isn't the right place for this, but
>         nor is test/Headers (which contains tests for the
>         compiler-supplied headers in lib/Headers).
>
>
>     test/Headers contains tests against installed system headers as
>     well as compiler-supplied headers right now (eg. cxx11.cpp,
>     carbon.c) so it's not quite so clear cut.
>
>
> Yes, it's odd for carbon.c to be there. test/Headers/cxx11.cpp tests 
> the lib/Headers headers (or at least intends to do so), so it's in the 
> right place.
>
>         This seems like kind of a random and strange test to have at
>         all, but if we really want this, test/Misc might be a better
>         place.
>
>
>     I agree it'd be preferable to keep tests like this in their own
>     place. That way they can be easily disabled when installed headers
>     become incompatible as happened with PR18322 -- especially useful
>     when bisecting historic builds on a more modern system.
>
>     Not sure that test/Misc is the right place. How about introducing
>     test/Integration for tests that cover integration with system headers?
>
>
> Yes, that sounds like a good place for carbon.c and cocoa.m (and 
> probably eventually a test that includes windows.h, and so on).
>
> warn-sysheader.cpp looks like it doesn't belong in test/Headers 
> either; it should probably be in test/Misc with the other tests for 
> the diagnostics infrastructure.
>
>     Alp.
>
>
>
>             Added:
>                 cfe/trunk/test/Headers/cocoa.m
>                   - copied, changed from r206686,
>         cfe/trunk/test/SemaObjC/cocoa.m
>             Removed:
>                 cfe/trunk/test/SemaObjC/cocoa.m
>
>             Copied: cfe/trunk/test/Headers/cocoa.m (from r206686,
>             cfe/trunk/test/SemaObjC/cocoa.m)
>             URL:
>         http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Headers/cocoa.m?p2=cfe/trunk/test/Headers/cocoa.m&p1=cfe/trunk/test/SemaObjC/cocoa.m&r1=206686&r2=206687&rev=206687&view=diff
>            
>         ==============================================================================
>             --- cfe/trunk/test/SemaObjC/cocoa.m (original)
>             +++ cfe/trunk/test/Headers/cocoa.m Sat Apr 19 14:07:24 2014
>             @@ -1,4 +1,4 @@
>             -// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang
>         -print-stats
>             +// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang
>         -print-stats
>              #ifdef __APPLE__
>              #include <Cocoa/Cocoa.h>
>              #endif
>
>             Removed: cfe/trunk/test/SemaObjC/cocoa.m
>             URL:
>         http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaObjC/cocoa.m?rev=206686&view=auto
>            
>         ==============================================================================
>             --- cfe/trunk/test/SemaObjC/cocoa.m (original)
>             +++ cfe/trunk/test/SemaObjC/cocoa.m (removed)
>             @@ -1,5 +0,0 @@
>             -// RUN: %clang -arch x86_64 %s -fsyntax-only -Xclang
>         -print-stats
>             -#ifdef __APPLE__
>             -#include <Cocoa/Cocoa.h>
>             -#endif
>             -
>
>
>             _______________________________________________
>             cfe-commits mailing list
>         cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>
>         <mailto:cfe-commits at cs.uiuc.edu <mailto:cfe-commits at cs.uiuc.edu>>
>         http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
>
>     -- 
>     http://www.nuanti.com
>     the browser experts
>
>

-- 
http://www.nuanti.com
the browser experts