r207896 - Fix a bunch of mislayered clang/Lex includes from Sema

Chandler Carruth chandlerc at google.com
Sat May 3 01:35:33 PDT 2014


On Fri, May 2, 2014 at 8:45 PM, Alp Toker <alp at nuanti.com> wrote:

> Fix a bunch of mislayered clang/Lex includes from Sema


The direction of this change makes lots of sense, but this commit log isn't
really helpful for reviewers because you're actually making non-trivial
changes in order to fix the layering issues. It would be really helpful for
me at least to both split each change into its own commit unless they are
interdependent in some way, and to describe the nature of the layering fix
when it isn't just a "include the right header instead of the wrong header".
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140503/96541e88/attachment.html>


More information about the cfe-commits mailing list