r207567 - Android uses -fpic for aarch64.

[Logan Chien]

Hi Jiangning,

Sure.  Committed as r207642.  Thanks.

Sincerely,
Logan


On Wed, Apr 30, 2014 at 4:47 PM, Jiangning Liu <liujiangning1 at gmail.com>wrote:

> Hi Logan,
>
> I noticed you only added test case for aarch64.
>
> Actually we are merging aarch64 to arm64, so the current aarch64 port is
> going to be phased out and the name "arm64" will be changed to "aarch64"
> finally.
>
> So could you please also add RUN for arm64 target as well?
>
> Thanks,
> -Jiangning
>
>
> 2014-04-30 2:18 GMT+08:00 Logan Chien <tzuhsiang.chien at gmail.com>:
>
> Author: logan
>> Date: Tue Apr 29 13:18:58 2014
>> New Revision: 207567
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=207567&view=rev
>> Log:
>> Android uses -fpic for aarch64.
>>
>> Modified:
>>     cfe/trunk/lib/Driver/Tools.cpp
>>     cfe/trunk/test/Driver/pic.c
>>
>> Modified: cfe/trunk/lib/Driver/Tools.cpp
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/Tools.cpp?rev=207567&r1=207566&r2=207567&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/lib/Driver/Tools.cpp (original)
>> +++ cfe/trunk/lib/Driver/Tools.cpp Tue Apr 29 13:18:58 2014
>> @@ -2382,6 +2382,7 @@ void Clang::ConstructJob(Compilation &C,
>>      case llvm::Triple::armeb:
>>      case llvm::Triple::thumb:
>>      case llvm::Triple::thumbeb:
>> +    case llvm::Triple::aarch64:
>>      case llvm::Triple::mips:
>>      case llvm::Triple::mipsel:
>>      case llvm::Triple::mips64:
>>
>> Modified: cfe/trunk/test/Driver/pic.c
>> URL:
>> http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/pic.c?rev=207567&r1=207566&r2=207567&view=diff
>>
>> ==============================================================================
>> --- cfe/trunk/test/Driver/pic.c (original)
>> +++ cfe/trunk/test/Driver/pic.c Tue Apr 29 13:18:58 2014
>> @@ -217,3 +217,5 @@
>>  // RUN:   | FileCheck %s --check-prefix=CHECK-PIC1
>>  // RUN: %clang -c %s -target mipsel-linux-android -### 2>&1 \
>>  // RUN:   | FileCheck %s --check-prefix=CHECK-PIC1
>> +// RUN: %clang -c %s -target aarch64-linux-android -### 2>&1 \
>> +// RUN:   | FileCheck %s --check-prefix=CHECK-PIC1
>>
>>
>> _______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140430/15c8d02b/attachment.html>