SV: [PATCH] String plus char

[Anders Rönnholm]

I have run it on LibreOffice and LLVM with no bugs found and no false positives either.

//Anders
________________________________________
Från: thakis at google.com [thakis at google.com] för Nico Weber [thakis at chromium.org]
Skickat: den 25 april 2014 17:36
Till: Anders Rönnholm
Cc: Jordan Rose; cfe-commits at cs.uiuc.edu
Ämne: Re: [PATCH] String plus char

Have you run this warning on some large codebase (test codebases we've
used in the past include LLVM itself, Chromium, Firefox, OpenOffice)
and measured how many bugs and false positives it causes?

On Fri, Apr 25, 2014 at 3:24 AM, Anders Rönnholm
<Anders.Ronnholm at evidente.se> wrote:
> Your right. I think it's a left over from when i first tried to cast it to an arraysubscriptexpr.
>
> Here is a new patch with array type removed.
>
> //Anders
> ________________________________________
> Från: Jordan Rose [jordan_rose at apple.com]
> Skickat: den 24 april 2014 18:43
> Till: Anders Rönnholm
> Cc: cfe-commits at cs.uiuc.edu
> Ämne: Re: [PATCH] String plus char
>
> If we're not looking through implicit casts, when would there ever be a case when the StringRefExpr is a constant array type? Shouldn't it always decay to a pointer?
>
> Jordan
>
>
> On Apr 17, 2014, at 5:19 , Anders Rönnholm <Anders.Ronnholm at evidente.se> wrote:
>
>> Hi,
>>
>> I have made some improvements on the string plus char warning.
>>
>> It can now also handle arrays, struct members and return values from function calls.
>>
>> e.q
>>
>> ab->a + 'b';
>>
>> foo() + 'c';
>>
>> char *strArr2[] = {"ac","dc"};
>> str = strArr2[0] + 'c';
>>
>> //Anders
>> <stringpluschar.diff>_______________________________________________
>> cfe-commits mailing list
>> cfe-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>