[PATCH] PR19601: return value for std::remove_if not used

[Richard Smith]

On Tue, Apr 29, 2014 at 2:05 PM, Chandler Carruth <chandlerc at google.com>wrote:

>
> On Tue, Apr 29, 2014 at 1:17 PM, Arnaud Allard de Grandmaison <
> arnaud.adegm at gmail.com> wrote:
>
>> In clang/lib/Tooling/CompilationDatabase.cpp:241, this really looks weird:
>>
>>    // Remove -no-integrated-as; it's not used for syntax checking,
>>    // and it confuses targets which don't support this option.
>>    std::remove_if(Args.begin(), Args.end(),
>>                  MatchesAny(std::string("-no-integrated-as")));
>>
>> The attached patch adds the extra erase step necessary to really remove
>> the elements --- as the comment states. But it bothers me to see that the
>> current code seems to work as it is, hinting that those lines may no longer
>> be necessary.
>>
>
> I don't see how those lines work as is. I think they are only working in
> the absence of that flag.
>

I guess integrated-as works on Win32 now? Either that, or the test is
broken too.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140429/cc96bd15/attachment.html>