r207319 - libclang: remove 'CXDiagnostic_Remark'

Tobias Grosser tobias at grosser.es
Mon Apr 28 01:06:43 PDT 2014


On 26/04/2014 16:43, Alp Toker wrote:
> Author: alp
> Date: Sat Apr 26 09:43:53 2014
> New Revision: 207319
>
> URL: http://llvm.org/viewvc/llvm-project?rev=207319&view=rev
> Log:
> libclang: remove 'CXDiagnostic_Remark'
>
> The change was landed without review or test cases.

Hi Alp,

thanks for getting back to this. At the time of commit I interpreted 
your OK wrongly and for some unexplainable reason I never came back to 
your email. I would have prefered a quick ping instead of just reverting 
this, but as I missed to reply to your original mail the error is fully 
on my side.

I already started to address your previously listed concerns (see the 
VerifyDiagnosticConsumer patch) and will repost this patch to discuss 
the backward compatibility issues you see.

Thanks again for making sure everything is properly reviewed,
Tobias



More information about the cfe-commits mailing list