r207107 - CommentToXMLConverter: Don't use "default" to method(s). It is unavailable in msc17.

Jordan Rose jordan_rose at apple.com
Thu Apr 24 09:37:17 PDT 2014


Should we have an LLVM_DEFAULTED_FUNCTION for this? Defaulted functions are ever so slightly more efficient in some cases because they can still be trivial.

Jordan


On Apr 24, 2014, at 5:44 , NAKAMURA Takumi <geek4civic at gmail.com> wrote:

> Author: chapuni
> Date: Thu Apr 24 07:44:34 2014
> New Revision: 207107
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=207107&view=rev
> Log:
> CommentToXMLConverter: Don't use "default" to method(s). It is unavailable in msc17.
> 
> Modified:
>    cfe/trunk/lib/Index/CommentToXML.cpp
> 
> Modified: cfe/trunk/lib/Index/CommentToXML.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Index/CommentToXML.cpp?rev=207107&r1=207106&r2=207107&view=diff
> ==============================================================================
> --- cfe/trunk/lib/Index/CommentToXML.cpp (original)
> +++ cfe/trunk/lib/Index/CommentToXML.cpp Thu Apr 24 07:44:34 2014
> @@ -1137,7 +1137,7 @@ void CommentASTToXMLConverter::appendToR
> }
> 
> CommentToXMLConverter::CommentToXMLConverter() : FormatInMemoryUniqueId(0) {}
> -CommentToXMLConverter::~CommentToXMLConverter() = default;
> +CommentToXMLConverter::~CommentToXMLConverter() {}
> 
> void CommentToXMLConverter::convertCommentToHTML(const FullComment *FC,
>                                                  SmallVectorImpl<char> &HTML,
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits




More information about the cfe-commits mailing list