r206995 - Review feedback

Robinson, Paul Paul_Robinson at playstation.sony.com
Wed Apr 23 11:22:03 PDT 2014


> -----Original Message-----
> From: cfe-commits-bounces at cs.uiuc.edu [mailto:cfe-commits-
> bounces at cs.uiuc.edu] On Behalf Of Diego Novillo
> Sent: Wednesday, April 23, 2014 8:21 AM
> To: cfe-commits at cs.uiuc.edu
> Subject: r206995 - Review feedback
...
>  In particular, sample profilers can provide execution counts for all
> -instructions in the code, information on branches taken and function
> +instructions in the code and information on branches taken and function

This reads better with the comma. (It's debatable whether there should
be a second comma before "and function" (the interminable "serial comma"
debate)).
--paulr

>  invocation. The compiler can use this information in its optimization
>  cost models. For example, knowing that a branch is taken very
>  frequently helps the compiler make better decisions when ordering
>  basic blocks. Knowing that a function ``foo`` is called more
> -frequently than another ``bar`` helps the inliner.
> +frequently than another function ``bar`` helps the inliner.






More information about the cfe-commits mailing list