[PATCH] don't diagnose -Wchar-subscript for safe char literal

Richard Smith richard at metafoo.co.uk
Wed Apr 23 11:17:51 PDT 2014


On Wed, Apr 23, 2014 at 11:08 AM, Daniel Marjamäki <
Daniel.Marjamaki at evidente.se> wrote:
>
> Sorry.. I changed my mind and in my humble opinion, I do think that
> foo['\xFF'] deserves a warning. However I am skeptic about foo[-1].


Seems my message was not clear enough. I also think we should warn on
foo['\xff'] but not on foo[-1].
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140423/430403ff/attachment.html>


More information about the cfe-commits mailing list