r206997 - Review feedback.

[Diego Novillo]

On Wed, Apr 23, 2014 at 1:10 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Apr 23, 2014 at 8:21 AM, Diego Novillo <dnovillo at google.com>
> wrote:
> > Author: dnovillo
> > Date: Wed Apr 23 10:21:23 2014
> > New Revision: 206997
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=206997&view=rev
> > Log:
> > Review feedback.
>
> It's useful to mention what the actual change is (even if it's
> something simple like "correct grammar") on the first line of the
> commit message.
>
> Then I usually put "Code review feedback from rXXXX by John Smith"
> after a blank line, so people can search for the revision number and
> find the original commit/code review feedback/context/etc.
>

As I said in
http://lists.cs.uiuc.edu/pipermail/cfe-commits/Week-of-Mon-20140421/103806.html,
this was me not rebasing my changes before the commit.  All the actual
conversation happened in the thread.  Phabricator just makes it hard to mix
the two things, which causes issues like this one when you're not paying
enough attention.

Diego.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140423/8e7038af/attachment.html>