[PATCH] MinGW toolchain

David Majnemer david.majnemer at gmail.com
Fri Apr 18 17:17:16 PDT 2014



================
Comment at: lib/Driver/MinGWToolChain.cpp:33
@@ +32,3 @@
+  : ToolChain(D, Triple, Args) {
+  //TODO: libc++ directory
+
----------------
This todo is pretty vague, can you add more context?

================
Comment at: lib/Driver/MinGWToolChain.cpp:48
@@ +47,3 @@
+      GCCVersion = llvm::sys::path::filename(entry->path());
+    //TODO report error: "no MinGW-w64 GCC installation found"
+  }
----------------
Need a space before the start of the comment.


http://reviews.llvm.org/D3420






More information about the cfe-commits mailing list