[PATCH][ARM64] Fix predefines and add plumbing for -mfpu=

[James Molloy]

Hi Tim,

I can try and split the bigger patch up if you like, although I did try that and ended up with a slew of test failures. I can try again.

Nice catch with the NetBSD case, I'll fix that!

As for tests, unless my greps are failing me there don't seem to be any. The closest I've got is the -mfpu and -mgeneral_regs_only tests, which are enabled as part of the second patch.

Cheers,

James

> -----Original Message-----
> From: Tim Northover [mailto:t.p.northover at gmail.com]
> Sent: 16 April 2014 13:47
> To: James Molloy
> Cc: cfe-commits at cs.uiuc.edu
> Subject: Re: [PATCH][ARM64] Fix predefines and add plumbing for -mfpu=
>
> Hi James,
>
> Mostly looks OK, though it might be better off as a couple of commits:
> I can see combining predefines & BE, but NEON looks a bit peripheral.
>
> +    case llvm::Triple::NetBSD:
> +      return new NetBSDTargetInfo<AArch64leTargetInfo>(Triple);
>
> Shouldn't that be ARM64 for now? (& Big-endian case).
>
> Also, isn't there some AArch64 predefine test you can hook into to
> make sure we actually are emitting the right ones? It looks like all
> of your test changes are just of the "-target-feature neon" kind.
>
> Cheers.
>
> Tim.


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.

ARM Limited, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2557590
ARM Holdings plc, Registered office 110 Fulbourn Road, Cambridge CB1 9NJ, Registered in England & Wales, Company No:  2548782