[PATCH] don't diagnose -Wchar-subscript for safe char literal

Richard Smith richard at metafoo.co.uk
Mon Apr 14 11:44:23 PDT 2014


This doesn't look like it's quite enough: if the index's type is Char_S,
you should also check whether the value of the character literal is
negative.


On Fri, Apr 11, 2014 at 10:58 AM, Daniel Marjamäki <
Daniel.Marjamaki at evidente.se> wrote:

> Hello!
>
> I have made a fix for this bug:
> http://llvm.org/bugs/show_bug.cgi?id=18389
>
> Please review.
>
> Best regards,
> Daniel Marjamäki
>
>
> ..................................................................................................................
> Daniel Marjamäki Senior Engineer
> Evidente ES East AB  Warfvinges väg 34  SE-112 51 Stockholm  Sweden
>
> Mobile:                 +46 (0)709 12 42 62
> E-mail:                 Daniel.Marjamaki at evidente.se
>
> www.evidente.se
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140414/ae224ddb/attachment.html>


More information about the cfe-commits mailing list