r205609 - Basic: rename VisualStudio to Windows

Saleem Abdulrasool compnerd at compnerd.org
Sat Apr 5 16:24:12 PDT 2014


On Fri, Apr 4, 2014 at 1:30 AM, Timur Iskhodzhanov <timurrrr at google.com>wrote:

> The change LGTM, just wanted to note the commit message is not in sync
> with the change.
>

:-(...yeah, I realised that the commit message was off a bit too late.  The
change was what was intended though.

Thanks for pointing it out though!


> 2014-04-04 9:08 GMT+04:00 Saleem Abdulrasool <compnerd at compnerd.org>:
> > Author: compnerd
> > Date: Fri Apr  4 00:08:53 2014
> > New Revision: 205609
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=205609&view=rev
> > Log:
> > Basic: rename VisualStudio to Windows
> >
> > Visual Studio is the Integrated Development Environment.  The toolchain
> is
> > generally referred to MSVC.  Rename the target information to be more
> precise as
> > per the recommendation of Reid Kleckner.
> >
> > Modified:
> >     cfe/trunk/lib/Basic/Targets.cpp
> >
> > Modified: cfe/trunk/lib/Basic/Targets.cpp
> > URL:
> http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Basic/Targets.cpp?rev=205609&r1=205608&r2=205609&view=diff
> >
> ==============================================================================
> > --- cfe/trunk/lib/Basic/Targets.cpp (original)
> > +++ cfe/trunk/lib/Basic/Targets.cpp Fri Apr  4 00:08:53 2014
> > @@ -3066,9 +3066,9 @@ public:
> >  namespace {
> >
> >  // x86-32 Windows Visual Studio target
> > -class VisualStudioWindowsX86_32TargetInfo : public
> WindowsX86_32TargetInfo {
> > +class MicrosoftX86_32TargetInfo : public WindowsX86_32TargetInfo {
> >  public:
> > -  VisualStudioWindowsX86_32TargetInfo(const llvm::Triple &Triple)
> > +  MicrosoftX86_32TargetInfo(const llvm::Triple &Triple)
> >        : WindowsX86_32TargetInfo(Triple) {
> >      LongDoubleWidth = LongDoubleAlign = 64;
> >      LongDoubleFormat = &llvm::APFloat::IEEEdouble;
> > @@ -3300,9 +3300,9 @@ public:
> >
> >  namespace {
> >  // x86-64 Windows Visual Studio target
> > -class VisualStudioWindowsX86_64TargetInfo : public
> WindowsX86_64TargetInfo {
> > +class MicrosoftX86_64TargetInfo : public WindowsX86_64TargetInfo {
> >  public:
> > -  VisualStudioWindowsX86_64TargetInfo(const llvm::Triple &Triple)
> > +  MicrosoftX86_64TargetInfo(const llvm::Triple &Triple)
> >        : WindowsX86_64TargetInfo(Triple) {
> >      LongDoubleWidth = LongDoubleAlign = 64;
> >      LongDoubleFormat = &llvm::APFloat::IEEEdouble;
> > @@ -6290,7 +6290,7 @@ static TargetInfo *AllocateTarget(const
> >        case llvm::Triple::GNU:
> >          return new MinGWX86_32TargetInfo(Triple);
> >        case llvm::Triple::MSVC:
> > -        return new VisualStudioWindowsX86_32TargetInfo(Triple);
> > +        return new MicrosoftX86_32TargetInfo(Triple);
> >        }
> >      }
> >      case llvm::Triple::Haiku:
> > @@ -6333,7 +6333,7 @@ static TargetInfo *AllocateTarget(const
> >        case llvm::Triple::GNU:
> >          return new MinGWX86_64TargetInfo(Triple);
> >        case llvm::Triple::MSVC:
> > -        return new VisualStudioWindowsX86_64TargetInfo(Triple);
> > +        return new MicrosoftX86_64TargetInfo(Triple);
> >        }
> >      }
> >      case llvm::Triple::NaCl:
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at cs.uiuc.edu
> > http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>



-- 
Saleem Abdulrasool
compnerd (at) compnerd (dot) org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140405/ca128885/attachment.html>


More information about the cfe-commits mailing list