[PATCH] Extend the check to detect patterns like 'ptr.get() == nullptr'

Manuel Klimek klimek at google.com
Sat Apr 5 12:43:18 PDT 2014



================
Comment at: clang-tidy/misc/RedundantSmartptrGet.cpp:60
@@ +59,3 @@
+  const auto IsAKnownSmartptr = recordDecl(
+      anyOf(hasName("::std::unique_ptr"), hasName("::std::shard_ptr")));
+
----------------
Manuel Klimek wrote:
> Manuel Klimek wrote:
> > Manuel Klimek wrote:
> > > Manuel Klimek wrote:
> > > > Manuel Klimek wrote:
> > > > > There might be a missing test here (s/shard/shared/)
> > > > Trying again to see whether the mail gets through...
> > > And trying again...
> > Yet another try...
> And again...
And finally...


http://reviews.llvm.org/D3294






More information about the cfe-commits mailing list