[PATCH] Put macro redefinition warnings under -Wmacro-redefined

Richard Smith richard at metafoo.co.uk
Thu Apr 3 16:57:34 PDT 2014


  LGTM


================
Comment at: include/clang/Basic/DiagnosticGroups.td:51-52
@@ -50,3 +50,4 @@
 def BadArrayNewLength : DiagGroup<"bad-array-new-length">;
+def MacroRedefined : DiagGroup<"macro-redefined">;
 def BuiltinMacroRedefined : DiagGroup<"builtin-macro-redefined">;
 def BuiltinRequiresHeader : DiagGroup<"builtin-requires-header">;
----------------
Do you think there's value in making `BuiltinMacroRedefined` a subgroup of `MacroRedefined`? I'm torn here -- logically one is a subset of the other, but redefining a builtin macro is a more serious offense.


http://llvm-reviews.chandlerc.com/D3283

BRANCH
  macro-redef

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list