[PATCH] clang-format: Add SpacesInParenthesesStyle

Aaron Wishnick aaron.s.wishnick at gmail.com
Thu Apr 3 06:25:00 PDT 2014


This patch adds an option to control when spaces are added inside of
parentheses. My employer's style guide mandates that spaces go inside the
outermost pair of parentheses, but not the rest. For example:

if( someFunction(a, b, c) ) {
  doThing( f(x), f(g(x)) );
}

My attached patch implements this feature with a new option,
SpacesInParenthesesStyle, which can either be "Always" (the previous
behavior, and the default), or "Outermost", the new behavior used by my
organization.

Does this seem like a reasonable strategy? The new option defaults to the
previous behavior. I see that a different approach was taken with
SpaceBeforeParensOptions. I went with this approach, because the option
applies to spaces inserted inside of parentheses due to
SpacesInParentheses, SpaceInEmptyParentheses,
SpacesInCStyleCastParentheses, etc.

Thanks,
Aaron

N.B. I originally sent this to the cfe-dev list by mistake, sorry for the
noise!
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140403/29212b2a/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SpacesInParenthesesStyle.patch
Type: application/octet-stream
Size: 9337 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140403/29212b2a/attachment.obj>


More information about the cfe-commits mailing list