[PATCH] Clang support for 'optnone' attribute

Robinson, Paul Paul_Robinson at playstation.sony.com
Mon Mar 31 15:37:54 PDT 2014


> One minor nit, but otherwise everything looks great!
> 
> > Index: clang/include/clang/Basic/AttrDocs.td
> > ===================================================================
> > --- clang/include/clang/Basic/AttrDocs.td (revision 205240)
> > +++ clang/include/clang/Basic/AttrDocs.td (working copy)
> > @@ -952,3 +952,20 @@
> >    struct S {};
> >  }];
> >  }
> > +
> > +def OptnoneDocs : Documentation {
> > +  let Category = DocCatFunction;
> > +  let Heading = "optnone";
> 
> The heading isn't necessary here (you really only need it if the
> attribute spellings are drastically different or if you're grouping a
> bunch of attributes under the same heading). So you can just drop that
> off.

Done. r205255.  Fantastic!
--paulr

> 
> Thanks!
> 
> ~Aaron
> 
> On Mon, Mar 31, 2014 at 5:28 PM, Robinson, Paul
> <Paul_Robinson at playstation.sony.com> wrote:
> > Support the 'optnone' attribute in Clang (including documentation!).
> >
> > If this possibly looks familiar, I had actually submitted and gotten
> > approval for an equivalent patch quite some time ago, but then it
> > took a rather long time to get the LLVM support in, and I didn't want
> > to commit the Clang part until LLVM was willing to fulfill the
> contract.
> > In the meantime the attribute support in Clang has had shall we say a
> > few changes, so I figured a fresh patch was the best approach.
> >
> > Thanks,
> > --paulr
> >





More information about the cfe-commits mailing list