[PATCH] Sema: Implement DR317

Richard Smith richard at metafoo.co.uk
Sat Mar 29 23:29:18 PDT 2014


  LGTM


================
Comment at: lib/Sema/SemaDeclCXX.cpp:596
@@ -594,1 +595,3 @@
     Invalid = true;
+  } else if (!Old->isInlined() && Old->isDefined(Def) && New->isInlined()) {
+    // C++11 [dcl.fcn.spec]p4:
----------------
[micro-optimization] Maybe move the cheaper `New->isInlined()` check before the more expensive `Old->isDefined(Def)`?


http://llvm-reviews.chandlerc.com/D3220

BRANCH
  master

ARCANIST PROJECT
  clang



More information about the cfe-commits mailing list