[PATCH] Fix bool expression special case.

Manuel Klimek klimek at google.com
Thu Mar 27 04:26:58 PDT 2014


Done & Submitted as r204913


On Thu, Mar 27, 2014 at 11:44 AM, Daniel Jasper <djasper at google.com> wrote:

>
>
> ================
> Comment at: lib/Format/TokenAnnotator.cpp:48
> @@ +47,3 @@
> +    Contexts.back().InTemplateArgument =
> +        Left->Previous != NULL &&
> Left->Previous->Tok.isNot(tok::kw_template);
> +
> ----------------
> I think, this deserves a comment. After all, even in template<...> we are
> in a template argument, just not in one that concerns us. Or maybe, this is
> a matter of getting the names right. Is a template argument the same as a
> template parameter? Or is one used at the definition and one at the
> declaration?
>
>
> http://llvm-reviews.chandlerc.com/D3187
>
> BRANCH
>   fix-template-bool
>
> ARCANIST PROJECT
>   clang
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140327/8bba184b/attachment.html>


More information about the cfe-commits mailing list