[patch][pr17530] Prevent alias from pointing to weak aliases

Rafael EspĂ­ndola rafael.espindola at gmail.com
Wed Mar 26 16:28:29 PDT 2014


The llvm side of this was LGTMed, but unfortunately I failed to
noticed that clang could produce aliases to weak aliases, so the patch
got reverted pending changes to clang.

With llvm rejecting aliases to weak aliases, we have to decide what to
do with it in clang.

One option is to error. That is fairly reasonable since the user can
easily fix the code (see r204823
in compiler-rt for example). The issue is gcc incompatibility.

What this patch does instead is skip past the weak alias in clang and
warn the user that it is probably not the expected semantics.

The llvm patch is attached for reference.

Cheers,
Rafael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: llvm.patch
Type: text/x-patch
Size: 14844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140326/5595e6f3/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: clang.patch
Type: text/x-patch
Size: 4128 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140326/5595e6f3/attachment-0001.bin>


More information about the cfe-commits mailing list