[PATCH] preview patch for fixit for finding modules needing import/inclusion

John Thompson john.thompson.jtsoftware at gmail.com
Wed Mar 26 15:06:25 PDT 2014


  I've reworked this to do the check in CorrectTypo as suggested.  This is just a partial post, as I've omitted needed changes to other tests so we can focus on the key parts.  I basically would like to know if this is the right approach, and what needs to be done to make it right/better.

  Question: I saw that there was some code for handling missing imports, but I couldn't see where it searched the global module index, and my new test case (with the new code disabled) didn't trigger it.  Was it just for some special cases?

  Thanks.

  -John

Hi doug.gregor, rsmith,

http://llvm-reviews.chandlerc.com/D2671

CHANGE SINCE LAST DIFF
  http://llvm-reviews.chandlerc.com/D2671?vs=6814&id=8146#toc

Files:
  include/clang/Frontend/CompilerInstance.h
  include/clang/Frontend/ASTUnit.h
  include/clang/Basic/LangOptions.def
  include/clang/Basic/DiagnosticGroups.td
  include/clang/Basic/DiagnosticSemaKinds.td
  include/clang/Lex/ModuleLoader.h
  include/clang/Lex/HeaderSearch.h
  include/clang/Driver/Options.td
  include/clang/Serialization/ASTReader.h
  include/clang/Serialization/GlobalModuleIndex.h
  lib/Frontend/CompilerInstance.cpp
  lib/Frontend/CompilerInvocation.cpp
  lib/Sema/SemaLookup.cpp
  lib/Lex/HeaderSearch.cpp
  lib/Serialization/GlobalModuleIndex.cpp
  test/Modules/undefined-type-fixit1.cpp
  test/Modules/Inputs/undefined-type-fixit/public2sub.h
  test/Modules/Inputs/undefined-type-fixit/module.map
  test/Modules/Inputs/undefined-type-fixit/public1.h
  test/Modules/Inputs/undefined-type-fixit/public2.h
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D2671.2.patch
Type: text/x-patch
Size: 24807 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140326/5bf79b9e/attachment.bin>


More information about the cfe-commits mailing list