[PATCH] Fix PR19066 - 0-sized vftable in the presence of virtual inheritance

[Reid Kleckner]

  lgtm


================
Comment at: lib/AST/VTableBuilder.cpp:2798
@@ +2797,3 @@
+static bool isDirectVBase(const CXXRecordDecl *Base, const CXXRecordDecl *RD) {
+  for (const auto &I : RD->bases()) {
+    if (I.isVirtual() && I.getType()->getAsCXXRecordDecl() == Base)
----------------
"I" isn't an iterator, I'd give it a name like Spec, BS, BaseSpec, or something.


http://llvm-reviews.chandlerc.com/D3181