r204670 - Cleanup testcase by adding return statements and replacing CHECK-DAG's with

Eric Christopher echristo at gmail.com
Mon Mar 24 14:30:34 PDT 2014


Wait, how does this fix it? What non-determinism were we triggering
the other way?

-eric

On Mon, Mar 24, 2014 at 2:19 PM, Adrian Prantl <aprantl at apple.com> wrote:
> Author: adrian
> Date: Mon Mar 24 16:19:34 2014
> New Revision: 204670
>
> URL: http://llvm.org/viewvc/llvm-project?rev=204670&view=rev
> Log:
> Cleanup testcase by adding return statements and replacing CHECK-DAG's with
> plain old CHECKs.
>
> Follow-up to r204633.
>
> Modified:
>     cfe/trunk/test/CodeGenCXX/linetable-fnbegin.cpp
>
> Modified: cfe/trunk/test/CodeGenCXX/linetable-fnbegin.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/CodeGenCXX/linetable-fnbegin.cpp?rev=204670&r1=204669&r2=204670&view=diff
> ==============================================================================
> --- cfe/trunk/test/CodeGenCXX/linetable-fnbegin.cpp (original)
> +++ cfe/trunk/test/CodeGenCXX/linetable-fnbegin.cpp Mon Mar 24 16:19:34 2014
> @@ -4,21 +4,22 @@
>  // CHECK: define{{.*}}bar
>  // CHECK-NOT: define
>  // CHECK: ret {{.*}}, !dbg ![[DBG:.*]]
> -// CHECK-DAG: ![[HPP:.*]] = metadata !{metadata !"./template.hpp",
> -// CHECK-DAG: ![[BLOCK:.*]] = metadata !{{{.*}}, metadata ![[HPP]], {{.*}}} ; [ DW_TAG_lexical_block ]
> -// CHECK-DAG: ![[DBG]] = metadata !{i32 23, i32 0, metadata ![[BLOCK]], null}
> +// CHECK: ![[HPP:.*]] = metadata !{metadata !"./template.hpp",
> +// CHECK: ![[DBG]] = metadata !{i32 23, i32 0, metadata ![[BLOCK:.*]], null}
> +// CHECK: ![[BLOCK]] = metadata !{{{.*}}, metadata ![[HPP]], {{.*}}} ; [ DW_TAG_lexical_block ]
>  # 1 "./template.h" 1
>  template <typename T>
>  class Foo {
>  public:
> - int bar();
> +  int bar();
>  };
>  # 21 "./template.hpp"
>  template <typename T>
>  int Foo<T>::bar() {
> +  return 23;
>  }
>  int main (int argc, const char * argv[])
>  {
>    Foo<int> f;
> -  f.bar();
> +  return f.bar();
>  }
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits



More information about the cfe-commits mailing list