[PATCH] Fix atomic libcall.

Tim Northover t.p.northover at gmail.com
Mon Mar 24 02:27:48 PDT 2014


  Hi Logan,

  Very sorry for the delay, I decided I needed to think about it a little and never quite got around to it. I've got one question:


================
Comment at: lib/CodeGen/CGAtomic.cpp:479-480
@@ -478,2 +478,4 @@
     std::string LibCallName;
+    QualType LoweredMemTy =
+      MemTy->isPointerType() ? getContext().getIntPtrType() : MemTy;
     QualType RetTy;
----------------
Doesn't this assume that sizeof(int *) == sizeof(int)?


http://llvm-reviews.chandlerc.com/D3006



More information about the cfe-commits mailing list