[PATCH] Sema: Treat dllimport globals without explicit storage class as extern
nico.rieck at gmail.com
Sat Mar 22 10:15:58 PDT 2014
On 21.03.2014 01:19, Richard Smith wrote:
> * goes on the right.
> 'i' and 'e' should be capitalized.
That's what I get for copy & paste without looking closely... ;)
> You don't have any tests for the attribute being in the declarator chunks,
> rather than in the decl specifiers. Please add such tests.
Done, treating all three attribute placements the same, similar to other
attributes. I noticed that Clang and GCC handle such attributes
differently, i.e. GCC rejects something like
int *__attribute__((visibility("hidden"))) v;
> Move the getAttr into the assert, so we trivially remove the whole thing in
> an NDEBUG build.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 8987 bytes
Desc: not available
More information about the cfe-commits