r204517 - CGDebugInfo: At the end of EmitFunctionStart, Initialize PrevLoc to the

Eric Christopher echristo at gmail.com
Fri Mar 21 14:21:24 PDT 2014


> -  // Push function on region stack.
> +  // Push the function onto the lexical block stack.
>    llvm::MDNode *SPN = SP;
>    LexicalBlockStack.push_back(SPN);
> +  // Initialize PrevLoc to the location of the function header.
> +  PrevLoc = Loc;
> +

No guarantees that this is a "header" in any way :) We're also not
initializing it.

Also, are you sure this is the right fix? We seem to be pretty much
immediately setting PrevLoc to Loc any time we see a function. Are we
missing something somewhere else?

-eric



More information about the cfe-commits mailing list