[PATCH] Fix PR19172 -- wrong this adjustment calculated for virtual destructor in a class with complex inheritance

Alexey Samsonov samsonov at google.com
Thu Mar 20 06:37:34 PDT 2014



================
Comment at: lib/AST/VTableBuilder.cpp:2585
@@ -2584,3 +2584,3 @@
     return MethodVFTableLocations.end();
   }
 
----------------
Can you introduce a range_iterator for it instead?

================
Comment at: lib/AST/VTableBuilder.cpp:3296
@@ +3295,3 @@
+
+    for (auto I = Builder.vtable_locations_begin(),
+              E = Builder.vtable_locations_end();
----------------
and use
  for (auto I : Builder.vtable_locations()) {
    GlobalDecl GD = I.first;
    ...
  }


http://llvm-reviews.chandlerc.com/D3128



More information about the cfe-commits mailing list