[Patch][analyzer][Review request] Move MismatchedDeallocator checker from unix.* to cplusplus.* group.

Ted Kremenek kremenek at apple.com
Wed Mar 19 17:10:01 PDT 2014


More to the point, *should* we leave it as “unix”?  Anton’s proposed change was motivated by some conceptual dissonance here.

On Mar 19, 2014, at 5:08 PM, Ted Kremenek <kremenek at apple.com> wrote:

> You didn’t really answer my question.  What is the right answer here?
> 
> On Mar 19, 2014, at 2:05 PM, Jordan Rose <jordan_rose at apple.com> wrote:
> 
>> "unix" includes an awful lot of generic things (like malloc itself). Part of the problem here is that our "core" checkers are always on. We don't have "generic-but-not-required" checkers right now.
>> 
>> Jordan
>> 
>> 
>> On Mar 19, 2014, at 13:55, Ted Kremenek <kremenek at apple.com> wrote:
>> 
>>> By that argument, does it belong in “unix”?  What about Windows-specific allocators?
>>> 
>>> On Mar 19, 2014, at 1:45 PM, Jordan Rose <jordan_rose at apple.com> wrote:
>>> 
>>>> It's currently specific to C++, but I'm not sure it's inherently specific to C++. I can imagine the FreeBSD guys adding support for custom C allocators too. So I'm not sure it's worth moving.
>>>> 
>>>> Jordan
>>>> 
>>>> 
>>>> On Mar 19, 2014, at 13:27, Ted Kremenek <kremenek at apple.com> wrote:
>>>> 
>>>>> Seems fine to me.
>>>>> 
>>>>> On Mar 19, 2014, at 1:12 PM, Anton Yartsev <anton.yartsev at gmail.com> wrote:
>>>>> 
>>>>>> Hi!
>>>>>> 
>>>>>> Propose to move the MismatchedDeallocator checker from unix.* to cplusplus.* group if you don't think it's too late. This check is specific for C++.
>>>>>> 
>>>>>> -- 
>>>>>> Anton
>>>>>> 
>>>>>> <MismatchedDeallocator_rebase.patch>_______________________________________________
>>>>>> cfe-commits mailing list
>>>>>> cfe-commits at cs.uiuc.edu
>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits
>>>>> 
>>>> 
>>> 
>> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140319/7624672a/attachment.html>


More information about the cfe-commits mailing list