[PATCH] clang-tidy explicit constructor check: don't warn on copy or move constructors.

Alexander Kornienko alexfh at google.com
Wed Mar 19 13:33:08 PDT 2014


We won't warn on any copy or move constructors, including deleted ones. A
separate check for deleted constructor is not required. See the tests.
On 19 Mar 2014 20:57, "Manuel Klimek" <klimek at google.com> wrote:

>
>
> ================
> Comment at: clang-tidy/google/GoogleTidyModule.cpp:37
> @@ -36,3 +36,3 @@
>    if (Ctor->isOutOfLine() || Ctor->isExplicit() || Ctor->isImplicit() ||
> -      Ctor->isDeleted())
> +      Ctor->isCopyOrMoveConstructor())
>      return;
> ----------------
> And why do we want to warn on deleted constructors?
>
>
> http://llvm-reviews.chandlerc.com/D3122
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20140319/e63a319a/attachment.html>


More information about the cfe-commits mailing list